Django

Code

Ticket #2216 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

Filtering by a field having same name as the model results in AttributeError

Reported by: anonymous Assigned to: russellm
Milestone: Component: Database layer (models, ORM)
Version: SVN Keywords:
Cc: mir@noris.de Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

For model 

class Color(models.Model):
  color = models.TextField(maxlength=100)
  similar_colors = models.ManyToManyField("self")

filtering does not work by field "color": Color.objects.filter(color="Light") results in AttributeError?: 'RelatedObject?' object has no attribute 'column'

Without the similar_colors relation, the filtering works fine.

Attachments

Change History

06/23/06 04:04:48 changed by mir@noris.de

  • cc set to mir@noris.de.

Looks very similar to #1839 (ForeignKey?('self') with attribute name like model name breaks AddManipulator?().save()).

The error message is slightly different, so it's only *perhaps* a duplicate ;-)

06/27/06 05:46:57 changed by russellm

  • owner changed from adrian to russellm.

Looks like a problem with related_query_name() on RelatedObject? returning the wrong name. I'll look into it.

06/27/06 06:52:55 changed by russellm

It turns out that related_query_name() is ok - your model is an edge case invalid model that isn't currently identified. The field name color clashes with the query term for the m2m relation with self. We don't currently validate for clashes in query terms - but we should. I'm working on a fix.

06/27/06 07:25:30 changed by mir@noris.de

Russell, can you have a quick look at #1839 if your comment applies to it, too? It's also about the field_name==model_name, but in a on-to-many relationship, and the error message is different.

Michael

06/27/06 10:21:43 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [3215]) Fixes #2216 -- Added extra tests for model validity, and cleaned up warning messages for existing tests. Models are now invalid if the query string required to access a field (or related object) would clash with the name of another field (or related object). Previous tests only checked the accessor names, not the query string.

Add/Change #2216 (Filtering by a field having same name as the model results in AttributeError)




Change Properties
Action