Opened 12 years ago

Closed 12 years ago

#21512 closed Cleanup/optimization (fixed)

Test of model_fields and model_forms gives incomplete information about Pillow/PIL situation

Reported by: Vajrasky Kok Owned by: Vajrasky Kok
Component: Uncategorized Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

I ran the test of /tests/model_fields/test_imagefield.py. It skipped a lot of tests. Then I checked the source code.

@skipIf(Image is None, "PIL is required to test ImageField")

I installed PIL then I ran the test again. I got deprecation warning because I installed PIL not Pillow.

Change History (3)

comment:1 by Vajrasky Kok, 12 years ago

Has patch: set
Owner: changed from nobody to Vajrasky Kok
Status: new → assigned

Here is the PR: ​https://github.com/django/django/pull/1996

comment:2 by Simon Charette, 12 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Baptiste Mispelon <bmispelon@…>, 12 years ago

Resolution: → fixed
Status: assigned → closed

In 16d73d7416a7902703ee8022f093667f7ac9ef5b:

Fixed #21512 -- Added more complete information about Pillow and PIL in model_fields and model_forms tests.

Note: See TracTickets for help on using tickets.
Back to Top