[patch] Firefox JavaScript Console reports two warnings for admin script

[mike.capp@…]

"function removeEvent does not always return a value" at contrib/admin/media/js/core.js line 25

​MSDN docs state that detachEvent has no return, so we should presumably return true as we do for the removeEventListener path.

Incidentally (and somewhat offtopic) the addEvent in contrib/admin/media/js/admin/ordering.js appears to be an unnecessary duplicate of the one in core.js - the additional useCapture arg in this version isn't used by the only call to it.

variable e hides argument at contrib/admin/media/js/admin/DateTimeShortcuts.js line 220

The 'var' isn't necessary here; assigning to an undefined arg doesn't affect any variables with the same name in enclosing scopes. That is,

var e = 123;
function foo(e) { if (!e) e = 456; alert("in foo e is " + e); }
foo();
alert("outside foo e is " + e);

alerts 456 then 123. (Checked in FF, IE and Opera.)

[mike.capp@…]

[patch] Sorry, forgot to put this in the ticket title

[Mike Capp <mike.capp@…>]

Fixed by Adrian in [3287] - not sure why it was still showing up as New here.