Opened 11 years ago
Closed 11 years ago
#21406 closed Bug (fixed)
blocktrans trimmed mixes up po-file source line numbers
Reported by: | Bouke Haarsma | Owned by: | Bouke Haarsma |
---|---|---|---|
Component: | Internationalization | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | bouke@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently when makemessages generates a po-file from a template, it uses an intermediate format as templates cannot be fed into gettext. This intermediate Python file follows the same structure as the original template file, such that the source line numbers match up. However with blocktrans new trimmed
option, the intermediate format is not adjusted and as a result the line numbers of translations following after that tag are mixed up.
Attachments (1)
Change History (5)
by , 11 years ago
Attachment: | 21406-proof.diff added |
---|
comment:1 by , 11 years ago
Cc: | added |
---|
comment:2 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Type: | Uncategorized → Bug |
comment:3 by , 11 years ago
Has patch: | set |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:4 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In 91c38ce4b236e6eeb5f6f636250df7316fa766bd:
Fixed 21406 -- Made blocktrans 'trimmed' option preserve line numbers.
Thanks Bouke Haarsma for report, fix and initial patch.
PR: https://github.com/django/django/pull/1894