Migrations created in wrong directory for models defined in model package

[anonymous]

Django supports to split a bunch of models into a separate Python modules which are placed in a models Python package. However the django.db.migrations.writer.MigrationWriter does not reflect this fact in its path property.

The solution is easy:

If myapp.models is a Python app_module (currently line 61) has a __path__ attribute. If it is a Python module there is no such attribute.

I'm going to write a patch and open a pull request for further discussion.

[Markus Holtermann <info@…>]

The pull request is at ​https://github.com/django/django/pull/1763

Right know I don't have a clue how to write a test case for this issue.

[Tim Graham]

Could you make a separate test app like "migrations_model_package" and make sure migrations are properly generated there?

[loic84]

@timo, shouldn't this use the app cache methods that you reworked at some point to better deal with models in exotic locations?

As for testing, dunno if this is going to play nice with MIGRATION_MODULES that we need to use in tests.

[Tim Graham]

That would be get_app_path() introduced in 31c13a99bb9ebdaf12ccab4e880c5da930d86e79, I think.

[loic84]

I had a go at this ​https://github.com/django/django/pull/1772, feedback welcome.

[Tim Graham <timograham@…>]

In 584110417f6a3c16cc0c6723825a21940a9a2bc4:

Fixed #21283 -- Added support for migrations if models is a package.

Thanks Markus Holtermann for the report.