Allow the strings the cycle tag uses to contain spaces

[anonymous]

I would like to be able to use the cycle tag like so:

{% cycle <td class="tdClass">,</tr><tr><td class="tdClass"> %}

The current cycle tag (as I understand it) does not allow spaces or a way to escape spaces.

[rjwittams]

I think this would be better handled with a blockcycle tag.
Eg
{%blockcycle %}

<td class="tdClass">

{%next%}

</tr><tr><td class="tdClass">

{%endblockcycle %}

Not that I'm sure this example is very good....

[Chris Beaven]

Patch #1522 would fix this

[Adrian Holovaty]

Now that we have an intelligent string splitter in the template system, I'd like to change cycle in a backwards-incompatible way, so that you'd pass in strings, separated by spaces. Examples:

{% cycle 'value 1' 'value 2' %}
{% cycle 'value 1' 'value 2' 'value 3' %}
{% cycle 'value 1' 'value 2' as foo %}

Variables would be allowed as the cycle values, too:

{% cycle some_var 'some value' %}

[Gary Wilson <gary.wilson@…>]

Marking as accepted since Adrian stated how he would like this tag to change.

[chris.mcavoy@…]

Patch that changes behavior of cycle tag according to Adrian's description.

[EspenG]

I found a bug in the admin interface while using the patch attached to this ticket. I also looked around for more of the same bug in the admin interface but could not find any. Will upload a new patch that fixes this bug.

[EspenG]

Fixes a little bug in the admin interface

[Malcolm Tredinnick]

No need to put [patch] in the title any longer. We have the "has patch" flag for that purpose.

[Chris Beaven]

I'd like to see this with backwards compatibility which is possible: After checking for as something, you can see if there's only one bit left with commas, in which case use the old method.

[EspenG]

This patch is also got backwards compatibility.

[Chris Beaven]

new patch, reviewed and refactored

[Chris Beaven]

separate patch which should be applied - updates admin and databrowse templates to use new format

[Chris Beaven]

So just to clarify, 208.patch contains just the code and 208-update-templates.patch contains just the template changes.

[Chris Beaven]

(Thanks to Philippe Raoult for writing the new docs)

[Russell Keith-Magee]

(In [6153]) Fixed #208 -- Modernized the syntax of the cycle tag to allow for spaces and variables in cycle values. Thanks to SmileyChris and Chris McAvoy for their work on this.