Django admin log depends on User model having a field named id

[Ryan Leckey <leckey.ryan@…>]

See ​https://github.com/django/django/blob/master/django/contrib/admin/templatetags/log.py#L20

Either we need to document that a User's pk must be named id and be integral or refactor the code linked above to not depend on it.

[Ryan Leckey <leckey.ryan@…>]

Something like the following works in my application.

def render(self, context):
    entries = LogEntry.objects.all()
    if self.user is not None:
        entries = LogEntry.objects.filter(user__exact=self.user)
    context[self.varname] = entries.select_related('content_type', 'user')[:self.limit]
    return ''

[Aymeric Augustin]

I think that's the same problem as #20049.

[Ryan Leckey <leckey.ryan@…>]

No. #20049 is about the models themselves being incapable to be acted upon if they have non-integer primary keys (I actually don't encounter that bug using mysql and InnoDB).

This issue causes Login to fail as the get_admin_log template tag is attempting to retrieve users by a relation lookup. If you change the linked code to the snippet above it works (at least in my application).

[Aymeric Augustin]

Mmm, right, this could probably be fixed independently.

[Juan Catalano <jc@…>]

In 054ce2aa02c88221ffa5665a4b9a5739cbbd0a39:

Fixed #20088 -- Changed get_admin_log not to depend on User id field

Before this change, the get_admin_log method would expect User model's
FK to be named id. When changing that FK name, admin/index.html
rendering would fail.

This includes:

• Changed the use of id for the use of pk property.
• Added a regression test that fails without the patch.

This commit refs #20088.

[Preston Holmes <preston@…>]

In 7a3409fc645c3e9c839fef08f05ec3bbcd9fb9cb:

Merge pull request #931 from catalanojuan/fix-admin-log-dependency-on-user-id-field-20088

Fixed #20088 -- Changed get_admin_log not to depend on User id field