Django

Code

Ticket #1888 (closed: fixed)

Opened 3 years ago

Last modified 1 year ago

Small interface inaccuracy when using filter_interface=models.VERTICAL

Reported by: wnielson Assigned to: ryankanno
Milestone: Component: django.contrib.admin
Version: Keywords: sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

when using 

models.ManyToManyField(filter_interface=models.VERTICAL)

the arrow icon next to 

Select your choice(s) and click

points to the right and should point down. In addition, 

'Choose all', 'Clear all'

options do not appear in this mode.

Attachments

django_filter_interface.diff (1.2 kB) - added by ryankanno on 09/14/07 17:51:25.
more DRY as suggested by SmileyChris?

Change History

10/24/06 15:49:22 changed by adrian

  • summary changed from 'Select your choice(s) and click' issues to Small interface inaccuracy when using filter_interface=models.VERTICAL.

01/31/07 21:55:24 changed by SmileyChris

  • stage changed from Unreviewed to Accepted.

Albiet small, it sounds like a valid bug.

09/14/07 17:31:15 changed by ryankanno

  • owner changed from nobody to ryankanno.
  • has_patch set to 1.

Widgets.css has the following: 

.stacked .selector-chooseall, .stacked .selector-clearall { display:none; }

so it's apparent chooseall and clearall were hidden for models.VERTICAL. The attached patch corrects the other small issue.

09/14/07 17:33:37 changed by ryankanno

  • keywords set to sprintsept14.

09/14/07 17:51:25 changed by ryankanno

  • attachment django_filter_interface.diff added.

more DRY as suggested by SmileyChris?

09/14/07 17:52:29 changed by SmileyChris

  • stage changed from Accepted to Ready for checkin.

09/15/07 00:01:58 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [6262]) Fixed #1888 -- Fixed small interface inaccuracy when using filter_interface=models.VERTICAL. Thanks, ryankanno, wnielson and SmileyChris?

Add/Change #1888 (Small interface inaccuracy when using filter_interface=models.VERTICAL)




Change Properties
Action