Opened 20 years ago

Closed 19 years ago

Last modified 15 years ago

#1829 closed defect (wontfix)

[patch] Move comments app URLconf to django.contrib.comments.urls

Reported by: Alex Dedul Owned by: nobody
Component: contrib.comments Version:
Severity: normal Keywords: sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This way it will be more consistent with new shorten admin URLconf path after MR and have, well, shorten and nicer look.

Attachments (1)

comments-url.diff​ (2.2 KB ) - added by Jannis Leidel <jl@…> 20 years ago.
Moved django.contrib.comments.urls.comments to django.contrib.comments.urls

Download all attachments as: .zip

Change History (12)

comment:1 by Adrian Holovaty, 20 years ago

#2017 was a duplicate.

comment:2 by Link, 20 years ago

Type: task → defect

comment:3 by Adrian Holovaty, 20 years ago

Status: new → assigned

comment:4 by Adrian Holovaty, 20 years ago

Component: Tools → django.contrib.comments

comment:5 by jimmy stahler, 20 years ago

Component: django.contrib.comments → Template system
Keywords: smily added
Needs documentation: set
Patch needs improvement: set
Resolution: → fixed
Status: assigned → closed
Summary: Move comments app URLconf to django.contrib.comments.urls → ;-]''''''''''
Triage Stage: Unreviewed → Accepted
Version: → other branch

;-]

==[]



comment:6 by Alex Dedul, 20 years ago

Component: Template system → django.contrib.comments
Keywords: smily removed
Needs documentation: unset
Patch needs improvement: unset
Resolution: fixed
Status: closed → reopened
Summary: ;-]'''''''''' → Move comments app URLconf to django.contrib.comments.urls
Triage Stage: Accepted → Unreviewed
Version: other branch

Reverted spam.

comment:7 by Simon G. <dev@…>, 20 years ago

Triage Stage: Unreviewed → Accepted

by Jannis Leidel <jl@…>, 20 years ago

Attachment: comments-url.diff​ added

Moved django.contrib.comments.urls.comments to django.contrib.comments.urls

comment:8 by Jannis Leidel <jl@…>, 20 years ago

Has patch: set
Summary: Move comments app URLconf to django.contrib.comments.urls → [patch] Move comments app URLconf to django.contrib.comments.urls

comment:9 by James Bennett, 19 years ago

Keywords: sprintsept14 added
Triage Stage: Accepted → Ready for checkin

Tentatively marking ready for checking, but this is backwards-incompatible and would have to be documented as such.

comment:10 by Malcolm Tredinnick, 19 years ago

Resolution: → wontfix
Status: reopened → closed

Given our plan to replace contrib.comments prior to 1.0, I think it's not worth introducing this backwards incompatibility that won't even last a single release. It's something that could be done in the new version, but I think it's wontfix for the current code.

comment:11 by Jacob, 15 years ago

milestone: 1.0 beta

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top