next_day from views.generic.dates.DayArchiveView returns None instead of today

[justin@…]

The next_day from views.generic.dates.DayArchiveView returns None when next_day would be today.

# in models.py
from django.db import models

class Post(models.Model):  
  pub_date = models.DateTimeField(auto_now_add=True)

# views.py
from django.views import generic
from bugdemo.models import *

class PostDayView(generic.DayArchiveView):
  queryset = Post.objects.all()
  date_field = 'pub_date'
  allow_empty = True
  allow_future = False

# urls.py
from django.conf.urls.defaults import patterns, include, url
from bugdemo.views import PostDayView

urlpatterns = patterns('',
  (r'^(?P<year>\d{4})/(?P<month>[a-z]{3})/(?P<day>\d{1,2})/$', PostDayView.as_view()),
)

# post_archive_day.html
Previous day: {{ previous_day }}
Next day: {{ next_day }}

# page request
$ curl http://localhost:8000/2011/nov/9/    # that's yesterday, as of the time of writing
Previous day: Nov. 8, 2011
Next day: None

Unless I misunderstand what the behavior is supposed to be, I expected the next_day to be datetime.date(2011, 11, 9), not None.

[Julien Phalip]

Looking at the code, the bug is most likely here: https://code.djangoproject.com/browser/django/trunk/django/views/generic/dates.py?rev=16974#L586

The condition should be a "less than or equal".

[Julien Phalip]

The problem appears to be in the old-style generic view too: https://code.djangoproject.com/browser/django/trunk/django/views/generic/date_based.py?rev=15989#L283
Even though it is deprecated, it is still supported and so it should be fixed as well.

[Piotr Banaszkiewicz]

I've done some tests and it appears that in elder generic views this particular bug is not present, although it certainly is for the new-style generic views.
I've included patch for it.

[Aymeric Augustin]

This was fixed as a side effect of the rewrite in 20e697368219603599649bc67aea5e087caedeae.

I'm going to add a regression test anyway.

[Aymeric Augustin <aymeric.augustin@…>]

In [ab268e18486b244f6633f2e013c12b6664a3661a]:

Added a test for DayArchiveView. Refs #17192.