ComentDetailsForm.clean_comment calls lower() in each iteration

[gasull@…]

I would change this line from

bad_words = [w for w in settings.PROFANITIES_LIST if w in comment.lower()]

to

lowercased_comment = comment.lower()
bad_words = [w for w in settings.PROFANITIES_LIST if w in lowercased_comment]

.

This way lower() won't need to be run on each iteration.

[Carl Meyer]

Ugh - this code is still in Django? I think it's about time to deprecate PROFANITIES_LIST and COMMENTS_ALLOW_PROFANITIES (the latter doesn't even seem to be documented, but its default value is False - i.e. block profanities.)

Anyway, as long as we've got the code it may as well not be stupidly inefficient. Thanks for the report!

[Alex Gaynor]

I'm closign as needsinfo, unless someone has a profile showing that this is a significant portion of a real request, there's no point to have addition code churn. Plus, as Carl notes, this code really should be deprecated.

[Luke Plant]

In 1.3 we said "No more naughty words" and waved off the Scunthorpe problem by setting PROFANITIES_LIST to an empty list by default, which is tantamount to deprecating the functionality. But technically we didn't deprecate the setting, and COMMENTS_ALLOW_PROFANITIES. We should do that for 1.4.