BaseGenericInlineFormSet does not use form's save() method

[Matt Austin]

Changeset [12268] introduced the save_new() method on BaseGenericInlineFormSet - however this uses creates a new object based on self.model and thehn uses save_instance(), bypassing any custom code on the form's save() method.

Would the following not provide the same functionality and honor the form's save() method?

    def save_new(self, form, commit=True):
        setattr(form.instance, self.ct_field.get_attname(),
            ContentType.objects.get_for_model(self.instance).pk)
        setattr(form.instance, self.ct_fk_field.get_attname(),
            self.instance.pk)
        return form.save(commit=commit)

[pyriku]

Attached the patch as described.

[polmuz]

I added a test for the patch provided by pyriku and created a pull request with it. ​https://github.com/django/django/pull/1599

[Tim Graham <timograham@…>]

In b11564fd36587b1077bf7d77b62b7879cc08c382:

Fixed #16869 -- BaseGenericInlineFormSet.save_new should use form's save() method

Thanks mattaustin for the report and Pablo Recio (pyriku) for the patch.

[Matt Austin]

Thanks for the patch/commit. Any chance of this being cherry-picked to Django 1.6, or are we too late?