Opened 13 years ago

Closed 13 years ago

#16548 closed Cleanup/optimization (fixed)

ImageField __init__ should use super()

Reported by: anonymous Owned by: pyriku
Component: Database layer (models, ORM) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

FileField.__init__(...)

should be changed to

super(ImageField.self).__init__(...)

Attachments (1)

image_field_super.diff​ (666 bytes ) - added by pyriku 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Matthias Kestenholz, 13 years ago

Component: Uncategorized → Database layer (models, ORM)
Easy pickings: set
Triage Stage: Unreviewed → Accepted

comment:2 by pyriku, 13 years ago

Has patch: set
Owner: changed from nobody to pyriku
Status: new → assigned
Triage Stage: Accepted → Ready for checkin

Attach the patch for this ticket

by pyriku, 13 years ago

Attachment: image_field_super.diff​ added

comment:3 by Aymeric Augustin, 13 years ago

Triage Stage: Ready for checkin → Accepted

The patch must be reviewed by someone else before it can be marked as ready for checkin.

See ​https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#ready-for-checkin

comment:4 by Aram Dulyan, 13 years ago

Triage Stage: Accepted → Ready for checkin

Reviewed patch, and ran test suite just to be overcautious.

comment:5 by Malcolm Tredinnick, 13 years ago

Resolution: → fixed
Status: assigned → closed

In [16658]:

Fix initialisation of ImageField super classes.

Fixes #16548, with thanks to pyriku.

Note: See TracTickets for help on using tickets.
Back to Top