module_has_submodule incorrectly uses the Importer Protocol

[Bradley Ayers <bradley.ayers@…>]

django.utils.module_loading.module_has_submodule has the code:

for finder in sys.meta_path:
    if finder.find_module(name):
        return True

where name is the absolute path to the module that should be imported. However PEP302 that defines the Importer Protocol says that a second argument must be supplied if the module isn't directly on sys.path.

Thus, the code should be:

for finder in sys.meta_path:
    if finder.find_module(name, package):
        return True

I came across this problem with using Attest, Django, and loading a template tag that had the same name as a package on my PATH.

[Alex Gaynor]

a) There's a typo in the patch, b) could use tests, c) <redacted> :)

[Bradley Ayers <bradley.ayers@…>]

Fixed typo

[Bradley Ayers <bradley.ayers@…>]

Added tests

[Jannis Leidel]

In [16075]:

Fixed #15662 -- Made sure the module_has_submodule utility function follow correct PEP 302, passing the package as the second argument to the find_module method of the importer. Thanks, Bradley Ayers.

[GitHub <noreply@…>]

In 9e9e7373:

Refs #23919 -- Removed an obsolete test for a Python 2 code path (refs #15662).

Fixed #21628 by removing the last usage of the imp module.