Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15588 closed Bug (fixed)

"FileField no longer deletes files" unclear

Reported by: philipn Owned by: nobody
Component: Documentation Version: 1.3-beta
Severity: Normal Keywords:
Cc: dmclain Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The new model <-> FileField behavior documentation is unclear. The way it's currently written leads one to believe that FileFields' delete method doesn't do anything on the disk. But if you call m.file.delete() the file is deleted from disk.

Attached a patch with some suggested wording.

Attachments (1)

filefield_doc.diff​ (1.6 KB ) - added by Philip Neustrom <philipn@…> 13 years ago.

Download all attachments as: .zip

Change History (8)

by Philip Neustrom <philipn@…>, 13 years ago

Attachment: filefield_doc.diff​ added

comment:1 by Gabriel Hurley, 13 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Luke Plant, 13 years ago

Type: → Bug

comment:3 by Luke Plant, 13 years ago

Severity: → Normal

comment:4 by dmclain, 13 years ago

Easy pickings: unset
Triage Stage: Accepted → Ready for checkin

The release notes are already out, as is 1.3, but this language does seem better and it applies cleanly. If updating the release notes is allowed, this patch is worth applying.

comment:5 by dmclain, 13 years ago

Cc: dmclain added

comment:6 by Chris Beaven, 13 years ago

Resolution: → fixed
Status: new → closed

In [16205]:

Fixes #15588 -- 1.3 release documentation for FileField no longer deleting files unclear. Thanks for the patch, Philip Neustrom.

comment:7 by Chris Beaven, 13 years ago

In [16206]:

[1.3.X] Fixes #15588 -- 1.3 release documentation for FileField no longer deleting files unclear. Thanks for the patch, Philip Neustrom.

Backport of r16205 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top