Opened 15 years ago

Closed 15 years ago

Last modified 14 years ago

#15491 closed (fixed)

HTML syntax errors in contrib.comments templates

Reported by: jonathanslenders Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

<meta /> should be terminated by a slash. (XHTML doctype.)

<!-- --> should be placed around CSS when the CSS contains a less-than, greater-than or ampersand. (contains greater-than sign.)

Attachments (1)

patch3.patch​ (1.1 KB ) - added by jonathanslenders 15 years ago.

Download all attachments as: .zip

Change History (5)

by jonathanslenders, 15 years ago

Attachment: patch3.patch​ added

comment:1 by Russell Keith-Magee, 15 years ago

Triage Stage: Unreviewed → Ready for checkin

A CDATA block is a better approach to fixing this, but point taken.

comment:2 by Russell Keith-Magee, 15 years ago

Resolution: → fixed
Status: new → closed

In [15642]:

Fixed #15491 -- Added a CDATA block and closed a stray tag in the comments HTML. Thanks to Jonathan Slenders for the report.

comment:3 by Russell Keith-Magee, 15 years ago

In [15644]:

(The changeset message doesn't reference this ticket)

comment:4 by Jacob, 14 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top