FileSystemStorage generates wrong URL when path contains special characters

[e.generalov]

I have a model with models.FileField and admin interface. When I upload any file that contains special characters in the name (for example test#12.jpg), then I can't to download it by link in the admin change form.

There is a bug in the FileSystemStorage URL generation algorithm. This doesn't escapes special characters. Therefore the '/media/test#12.jpg' URL is produced and browser treats #12.jpg as a fragment part.

I notice same bug in the ​https://github.com/sorl/sorl-thumbnail/blob/legacy/sorl/thumbnail/main.py#L96 too, where iri_to_uri() is used for filepath-to-uri convertion (this method gives a wrong result too).
Therefore I suggest to place such function in the django core (see the patch).

[Jannis Leidel]

Please don't set the triage stage to RFC as an anonymous user.

[Russell Keith-Magee]

Sorry - that was me.

[Russell Keith-Magee]

In [15409]:

Fixed #15181 -- Ensure that special characters are escaped when querying for the URL of an uploaded file. Thanks to e.generalov for the report and patch.

[Russell Keith-Magee]

In [15410]:

[1.2.X] Fixed #15181 -- Ensure that special characters are escaped when querying for the URL of an uploaded file. Thanks to e.generalov for the report and patch.

Backport of r15409 from trunk.

[Paul Egan]

NB: This change means that URLs stored in FileFields or ImageFields using the default storage are now handled differently.

Previously:

>>> from django.core.files.storage import DefaultStorage, settings
>>> settings.configure(MEDIA_URL='http://localhost')
>>> DefaultStorage().url('http://media/test')
'http://media/test'

Now:

>>> from django.core.files.storage import DefaultStorage, settings
>>> settings.configure(MEDIA_URL='http://localhost')
>>> DefaultStorage().url('http://media/test')
'http://localhost/http%3A//media/test'

[Russell Keith-Magee]

@paulegan: For future reference, regressions should be opened as a new ticket, not as continuing discussion on a closed ticket. I've opened #15521 to track this.