manage.py test fails if sites app not installed

[Waldemar Kornewald]

The unit tests of several contrib apps depend on the sites app even though the respective contrib app already falls back to RequestSite. The attached patch fixes the failing tests (at least the ones I've stumbled upon). Not sure how this patch relates to the proposed changes in #15089, though.

[Waldemar Kornewald]

patch against r15239

[Russell Keith-Magee]

Marking RFC because the patch is pretty much ready to use.

However, I have a suspicion that the very last delta is wrong (or at least requires additional thought). The call to get_current() is intended to populate a cache; it shouldn't be possible to remove that line without consequences.

[Waldemar Kornewald]

Maybe if the purpose of the last line is to check if the exception is raised even with the Site cache filled we might need a small extra change. But then I'd rather extend get_current(), so it's guaranteed to raise Site.DoesNotExist if Site._meta.installed is False and have a unit test in the sites app for that.

OTOH, I'd question the whole purpose of testing against a filled cache with Site._meta.installed set to False via a hack because then the unit test would verify if everything works correctly even if people use ugly hacks in their code (i.e., manipulating Site._meta.installed in production code).

[Russell Keith-Magee]

In [15418]:

Fixed #15111 -- Ensured that the auth, contenttypes and sitemaps tests will run when the sites app isn't installed. Thanks to Waldemar Kornewald for the report and draft patch.

[Russell Keith-Magee]

In [15419]:

[1.2.X] Fixed #15111 -- Ensured that the auth, contenttypes and sitemaps tests will run when the sites app isn't installed. Thanks to Waldemar Kornewald for the report and draft patch.

Backport of r15418 from trunk.

[Ramiro Morales]

In [15429]:

[1.2.X] Fixed small problem in backport of [15418] tests changes to 1.2.X ([15419]). Refs #15111.

[Jacob]

Milestone 1.3 deleted