URLField (in django.contrib.admin) rejects IDN domain

[Nedec]

I tried to add a new entry using the admin interface.
But when the URLField contains any unicode char (for IDN domains), like ​http://de.wikipedia.org/wiki/Tür, I am getting the following error:

Enter a valid URL.

According to the ​documentation, this bug was fixed in 1.2 and it does work in the shell:

>>> from django.core.validators import URLValidator
>>> v = URLValidator()
>>> v('http://de.wikipedia.org/wiki/Tür')
>>>

[Claude Paroz]

I can reproduce this error even in a standard form. This is not related to the admin.

[Claude Paroz]

After some research, this is related to the URL verification. Try:

>>> from django.core.validators import URLValidator
>>> v = URLValidator(verify_exists=True)
>>> v('http://de.wikipedia.org/wiki/Tür')
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)

/home/partage/Sauvegarde/Sites/bdn/Products/djangobdn/<ipython console> in <module>()

/usr/local/lib/python2.6/dist-packages/django/core/validators.pyc in __call__(self, value)
     85                 u = urllib2.urlopen(req)
     86             except ValueError:
---> 87                 raise ValidationError(_(u'Enter a valid URL.'), code='invalid')
     88             except: # urllib2.URLError, httplib.InvalidURL, etc.
     89                 raise ValidationError(_(u'This URL appears to be a broken link.'), code='invalid_link')

ValidationError: [u'Enter a valid URL.']

I'm attaching a patch that encodes url before passing it to urllib2. Testing is tricky, as it implies network access.

Note also that this is not solving IDN domain validation problem (#12988).

[Claude Paroz]

Encode url before passing it to urllib2.urlopen

[Claude Paroz]

With test

[Claude Paroz]

I saw there was already tests calling the network, so I added this one

[Jannis Leidel]

In [15504]:

Fixed #14941 -- Stop raising ValidationError in form fields that use the URLValidator and get a IDN domain passed. Thanks, Claude Paroz.

[Jannis Leidel]

In [15511]:

[1.2.X] Fixed #14941 -- Stop raising ValidationError in form fields that use the URLValidator and get a IDN domain passed. Thanks, Claude Paroz.

Backport from trunk (r15504).

[Jacob]

Milestone 1.3 deleted