django signals not thread-safe

[milosu]

django dispatcher.Signal methods connect and disconnect are not thread-safe, observed while using johnny cache

patch and test case attached

[milosu]

attached test case should crash some threads with the following exception:

Exception in thread Thread-99:
Traceback (most recent call last):
  File "c:\Python26\lib\threading.py", line 532, in __bootstrap_inner
    self.run()
  File "signal_ts.py", line 25, in run
    signals.post_delete.disconnect(self.handler2, sender=None)
  File "c:\Python26\lib\site-packages\django_versions\trunk\django\dispatch\dispatcher.py", line 141, in disconnect
    del self.receivers[index]
IndexError: list assignment index out of range

attached patch solves this problem for me and passes django test suite

[Maxim Bublis]

This bug affects me too. Patch is working for me.

[anonymous]

lock.release() should be done in a "finally:" cause.

[Arthur]

This patch helped me, but I'm not an expert for threading problems :).

[Honza Král]

(In [14662]) Fixed #14533 -- Make django signals more thread-safe. Thanks milosu for the patch!

[Jacob]

Milestone 1.3 deleted