Opened 14 years ago
Closed 12 years ago
#14478 closed Bug (fixed)
Couple of tests make assumptions about configuration
| Reported by: | Travis Swicegood | Owned by: | nobody |
|---|---|---|---|
| Component: | Contrib apps | Version: | dev |
| Severity: | Normal | Keywords: | tests |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
django.contrib.messages and django.contrib.sitemaps both run tests with certain assumptions that are not guaranteed. I've fixed both on my GitHub fork. They are available at:
- Fix messages tests: commit 1bc1fda
- Fix sitemaps tests: commit ad099a1
The patches are against master, but I have tested the same changes against 1.2.3 and they work there as well.
Attachments (1)
Change History (6)
comment:1 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
comment:3 by , 13 years ago
| Easy pickings: | unset |
|---|---|
| Has patch: | set |
| UI/UX: | unset |
| Version: | 1.2 → SVN |
The USE_I18N setting in sitemaps has been addressed in #14833
comment:5 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
The fix for sitemaps looks fine, but my inclination is that the messages test should restore
settings.TEMPLATE_CONTEXT_PROCESSORSin thetearDownmethod the way other tests do for maximum isolation.