"readonly" fields don't display their "help_text" in admin

[jester]

Steps to reproduce

1. Define a Model, whose field(s) specify help_text, e.g.:

class MyModel(Model):
    my_regular_field = CharField(max_length=255, help_text="this is my regular field")
    my_readonly_field = CharField(max_length=255, help_text="this is my readonly field")

2. Define a ModelAdmin for your Model, including one of its fields in readonly_fields, e.g.:

class MyModelAdmin(ModelAdmin):
    fields = 'my_regular_field', 'my_readonly_field'
    readonly_fields = 'my_readonly_field',
admin.site.register(MyModel, MyModelAdmin)

In the object view/edit screen, "My regular field" will have help text, "My readonly field" will not.

Expectation

The expected behavior is that readonly fields will work just like "regular" fields, except their widget will be their plain value rather than a form element -- i.e., any string specified as "help_text" should be displayed after the field.

Uneducated guesswork

I don't dig very deep into the workings of the admin very often, and so, obviously, what I'm about to say may be entirely unhelpful. However, it appears that helpers.AdminReadonlyField constructs a limited, faux field object, a dict, at self.field, rather than assign the appropriate BoundField instance. This is perhaps because readonly fields are not available to it in self.form.fields. In the template, field.field.field.help_text fails, as the dict does not contain "help_text", (and I'm not sure where AdminReadonlyField would get it, anyway).

[alexbmeng@…]

Added help_text to readonly admin fields

[Yeago]

removed exception

[Yeago]

removed exception

[Yeago]

removed exception

[Natalia Bidart]

I confirmed that the help text is not being shown in the admin add/change form, for a read only field.

The patch attached by the reporter does not include tests for this fix, so I'm setting this bug properties accordingly.

[wamberg]

git diff patch for help_text on readonly fields

[Julien Phalip]

Thank you alexbmeng, subsume and wamberg. Your latest patch looked good. I've just removed a line (self.help_text = ...) which was unnecessary and wrote some slightly more thorough tests. I believe this is RFC now.

[Russell Keith-Magee]

In [15582]:

Fixed #14355 -- Ensure that help_text is displayed for readonly fields in the admin. Thanks to jester for the report, and to alexbmeng, subsume, wamberg and Julien Phalip for ther work on the patch.

[Russell Keith-Magee]

In [15583]:

[1.2.X] Fixed #14355 -- Ensure that help_text is displayed for readonly fields in the admin. Thanks to jester for the report, and to alexbmeng, subsume, wamberg and Julien Phalip for ther work on the patch.

Backport of r15582 from trunk.

[Jacob]

Milestone 1.3 deleted