Django

Code

Ticket #1429 (closed: invalid)

Opened 3 years ago

Last modified 9 months ago

Yet another patch for SQL server adodbapi

Reported by: jdunck@gmail.com Assigned to: nobody
Milestone: Component: Database layer (models, ORM)
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 1
Needs tests: 0 Patch needs improvement: 1

Description

From Matt Good, this patch works for him on top of 0.91.

Needs to be merged in against 0.91, have dj tests pass, then translated to magic-removal and pass those.

Attachments

adodbapi-from-0.91.patch (19.5 kB) - added by anonymous on 02/28/06 19:48:53.

Change History

02/28/06 19:48:53 changed by anonymous

  • attachment adodbapi-from-0.91.patch added.

03/21/06 23:18:31 changed by Matt Good <django@matt-good.net>

Thanks for uploading that patch. I should note that in the ADO backend I made the connection a threading.local as an attempt to work around some threading problems I had, but that should probably be removed.

Also, the patch included a change I made in django.core.meta to allow nullable many-to-one relationships, which I've heard will no longer be necessary on the magic-removal branch.

The "mssql" backend in the patch is based on my "ado_mssql" backend and differs from the implementation in #1258 by parsing the LIMIT and OFFSET from the query instead of special-casing it in django.core.meta. There is a special-case for enabling IDENTITY_INSERT (though I realized it's not turned back off as done in #1258, which may be a good idea).

The pymssql module used in the "mssql" backend is currently GPL licensed, but I've contacted the authors and they are willing to relicense it under the LGPL. A new 0.8 release is supposed to be out shortly that will include the new license.

05/04/06 23:43:14 changed by adrian

#1258 was another attempt.

08/11/06 10:02:08 changed by Matt Good

This news is a little late, but the pymssql authors have changed the license to LGPL: http://sourceforge.net/forum/forum.php?forum_id=566339

08/13/06 00:40:45 changed by Gary Wilson <gary.wilson@gmail.com>

  • milestone changed from Version 0.92 to Version 1.0.

0.92 is long gone.

01/17/07 16:12:17 changed by

  • milestone deleted.

Milestone Version 1.0 deleted

01/24/07 22:45:16 changed by Gary Wilson <gary.wilson@gmail.com>

  • needs_better_patch set to 1.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.
  • version changed from magic-removal to SVN.
  • needs_docs set to 1.

Patch is out of date. magic-removal was already merged.

03/04/08 09:43:58 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to invalid.

As per #2358 and #3702, we're asking adosql development to be done out of tree for now.

Add/Change #1429 (Yet another patch for SQL server adodbapi)




Change Properties
Action