Login Required decorator should support LOGIN_URL

[m.hasnain.lakhani@…]

In django.contrib.auth.decorators, both the user_passes_test and permission_required decorators allow the caller to specify a custom LOGIN_URL to redirect visitors to. However, the login_required decorator does not allow the caller to specify a custom login URL. This feature would be helpful in my opinion and not hard to add.

[mhlakhani]

I added the patch. This should work.

[Brandon M Height]

I agree that this is easy to implement and see not reason why this could not be implemented on trunk.

Currently however you can already do this under the implementation of providing login_required with "function=your_own_decorator" under which you can implement your own version of the lambda statement.

I would however be +0 for implementing this as it is a nicety but there are ways to do this without modification to the django source.

[Chris Beaven]

You'd also want to make the new argument the last, as some people will be using positional arguments to call the decorator.

But yeah, it seems useful enough to add (and no backwards compatibility issues after the argument is moved to the end).

[mhlakhani]

The required patch.

[mhlakhani]

I've updated the patch, making the new argument the last as required.

[Chris Beaven]

Great, now just docs and tests to go :)

[floguy]

I've updated the patch to include docs and tests for this. It's all isolated in a branch here: ​http://github.com/ericflo/django/compare/ticket13714

[floguy]

Fixed in [13723]