Querysets should only allow the correct model types to be filtered against

[Chris Beaven]

Here's a simple example of what is allowed at the moment. It seems that this should throw an exception for the last line:

In [1]: from django.contrib.auth.models import *


In [3]: u = User.objects.all()[0]


In [5]: m = Message.objects.create(user=u, message='test')

In [6]: m.pk, u.pk
Out[6]: (1, 1)


In [10]: User.objects.filter(message=m)
Out[10]: [<User: chris_b>]

In [11]: User.objects.filter(message=u)
Out[11]: [<User: chris_b>]

[anonymous]

It seems last line wil not throw an exception but returns empty list

u = User.objects.all()[0]
m = Message.objects.create(user=u, message='test')
m

<Message: test>

u

<User: admin>

User.objects.filter(message=m)

[<User: admin>]

User.objects.filter(message=u)

[]

[Chris Beaven]

It depends on the primary key of your user, hence my line 6 output in the initial description showing they both have the id of 1

[Jacob]

Milestone 1.3 deleted

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Claude Paroz]

Fixed in #14334