Model does not call super __init__

[George Vilches]

In the Django Model class, super(Model, self).__init__ is never called. Since Django inherits from object, there is no backwards-compatibility issues by calling super.__init__, and it enables multiple-inheritance/mixins to work as expected in standard Python classes.

[George Vilches]

Enables support for Model.init super, against r12847.

[Alex Gaynor]

(In [15317]) Fixed #13206 -- call super().init() in Model.init to allow mixins to do things there.

[Alex Gaynor]

(In [15320]) [1.2.X] Fixed #13206 -- call super().init() in Model.init to allow mixins to do things there. Backport of [15317].

[alaa]

there is backwards compatibility issues with this change, init for sibling class in cases where there is multiple inheritance is now called when it wasn't called before, and called at a specific point in model construction.

code that used multiple inheritance with models would have had to explicitly call init or assume it never gets called, so I can't see how u consider this backward compatible.

that's a major change to introduce in a bug fix release (1.2.5), it is also an undocumented change.

it doesn't help with situation where there are more than two classes involved in the multiple inheritance, always calls the constructor at the end of the function when there are situations where it might be better called at the start, so I'm not sure it is better than letting client code explicitly call the constructor if required.

it also assumes init in all classes involved requires no arguments (should at least pass *args, kwargs).

[Carl Meyer]

Replying to alaa:

that's a major change to introduce in a bug fix release (1.2.5), it is also an undocumented change

it also assumes init in all classes involved requires no arguments (should at least pass *args, kwargs).

These are reasonable concerns, IMO, particularly the latter -- but reopening this ticket is the wrong place to raise them. The issue in this ticket has been fixed - if there are problems with the fix, we need another ticket that describes that problem. Or better, since I suspect some design judgment calls will be needed, bring it up for discussion on the django-developers mailing list.

[Tim Child]

I agree with alaa, is there a new ticket that has been created for this new issue?

[dmrschmidt]

Just found this ticket here and I actually DO have an issue with that one. I am using Mixins in some classes, passing them 4 arguments in their init. This now results in
TypeError "init() takes exactly 4 arguments (1 given)". So will there be a fix for this in 1.2.X?

[Jacob]

Milestone 1.3 deleted