Admin change view: ambiguity between action and list_editable form submission

[Paul Smith]

The Admin change view can have two simultaneous form interactions if there are actions AND there are list_editable fields. There will be two submit buttons: a 'Go' button for actions and a 'Save' button for list_editable changes (actually it could be three if actions_on_top and actions_on_bottom are both True). In cases where the user might change list_editable elements and hit the 'Go' button, or select an action to execute and hit 'Save', BOTH sets of changes get handled - an ambiguous and confusing situation that could potentially result in unintended consequences.

[Paul Smith]

Initial patch - needs tests, better warnings

[Paul Smith]

New patch, includes updated tests

[Paul Smith]

New patch: includes additions to actions.js that warn users when they're submitting ambiguous values.

[Paul Smith]

OK, now we have some tests, old tests have been updated, and there are some JavaScript warnings that will let the user know when they submit ambiguous values. Changing "Needs improvement" - ready to go.

[Jannis Leidel]

The confirmation messages ought to be marked for translation, as documented here: ​http://docs.djangoproject.com/en/1.1/topics/i18n/internationalization/#specifying-translation-strings-in-javascript-code

[Aymeric Augustin]

Updated patch that applies cleanly on r13045, with i18n added in javascript and minification, as required by jezdez.

[Gabriel Hurley]

I tested aaugustin's latest patch on my Windows XP system: it applies cleanly, the tests pass, and interacting with the list-editable/actions widgets produce what seem to be the correct set of confirmation dialogs and messages. Looks ok to me.

[Jannis Leidel]

(In [13072]) Fixed #13166 - Added JavaScript warnings to admin changelist to help against ambiguity between action and list_editable form submission. Thanks to blinkylights and aaugustin for the report and initial patch.

[Jacob]

Milestone 1.2 deleted