#1316 closed defect (fixed)
[patch] one more bug fix for admin interface
| Reported by: | jpaulofarias at gmail dot com | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | contrib.admin | Version: | magic-removal |
| Severity: | normal | Keywords: | admin, db |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Removed one more reference to 'get_%s_list' when it should be '%s_set'.all()
Index: django/db/models/base.py
===================================================================
--- django/db/models/base.py (revision 2230)
+++ django/db/models/base.py (working copy)
@@ -211,7 +211,7 @@
else:
sub_obj.__collect_sub_objects(seen_objs)
else:
- for sub_obj in getattr(self, 'get_%s_list' % rel_opts_name)():
+ for sub_obj in getattr(self, '%s_set' % rel_opts_name).all():
sub_obj.__collect_sub_objects(seen_objs)
def delete(self):
Note:
See TracTickets
for help on using tickets.
I believe the logic that creates the '_set' name is isolated in one place; i.e., '_set' shouldn't be hard-coded here.