#13124 closed (fixed)
function 'find_template_loader' doesn't work with PyPy 1.2
| Reported by: | avostryakov | Owned by: | nobody |
|---|---|---|---|
| Component: | Template system | Version: | 1.2-beta |
| Severity: | Keywords: | find template, pypy | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
I tested django template system under PyPy 1.2. Basically it works except one small line of code in function 'find_template_loader; (<root project's directory>/django/template/loader.py):
'if hasattr(loader, 'iter'):'
I suggest to replace this line with:
'if isinstance(loader, tuple):'
The patch is attached. I think it'll be better because a new code doesn't use a little tricky feature of python. Class 'string' doesn't have 'iter' attribute but can be iterated.
Attachments (1)
Change History (4)
by , 14 years ago
| Attachment: | find_template_loader_patch.diff added |
|---|
comment:1 by , 14 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
The test should be extended to also allow for lists, but otherwise a reasonable suggestion.