Support in syndication framework for CSS stylesheet links

[intrepidweb]

It would be very helpful to be able to add CSS stylesheets to feeds produced by the syndication framework. As far as I know, this is not possible now without overriding the write method of the feed class.

[Russell Keith-Magee]

I'm not aware of any CSS technique that works reliably for RSS or Atom feeds. This is largely because RSS is intended to be machine readable, not human readable.

If I'm mistaken, I'm open to suggestions on what technique we should be supporting.

[intrepidweb]

RSS feeds contain CSS and/or XSL stylesheets all the time. Here's a link on how to add an RSS stylesheet:

​http://www.oreillynet.com/pub/a/network/2005/07/01/rss.html

I tried to include a list of major websites that use stylesheets in their RSS feeds, but the spam filter blocked it. However, if you check the feeds of CNN, CBS News, Reuters, Newsweek, Time and many more, you'll see XSL and/or CSS stylesheets linked in the source.

[Yuval Adam]

Turns out easier than expected. saxutils supports adding XML processing instructions.

Added support for stylesheets, per the W3 spec, in the feedgenerator and in contrib.syndication.

[Yuval Adam]

Updated proposed patch, with tests and docs

[Aymeric Augustin]

Accepting based on comment 2.

[Tim Graham]

Updated the patch to apply cleanly, but noticed with the current implementation the stylesheets are only added to RSS feeds and not ATOM feeds. Does ATOM not support stylesheets?

[Collin Anderson]

Is this still useful now that browsers have dropped the RSS button?

[Tim Graham]

I think it's still relevant. feedburner styles their feeds for example. I updated the patch to apply cleanly again, but we do need to add support for stylesheets in the ATOM feedgenerator (I started this, but didn't make the test updates). Also, I think we should avoid hardcoding text/css since stylesheets could also be xsl. Maybe extracting the stylesheet extension is enough or maybe the stylehseets attribute should be tuples of ('stylesheet', 'type'). Finally, the patch is also missing release notes.

[Sarah Boyce]

#35420 possible duplicate, with patch: ​https://github.com/django/django/pull/18120

[Sarah Boyce]

Patch is missing support for CSS stylesheets 👍

[Baptiste Mispelon]

I've added support for CSS stylesheets as well and updated the PR.

[Sarah Boyce]

Tested using the test project provided by Baptiste and is working well: ​https://github.com/bmispelon/django-ticket-35420
Have minor comments on the PR but the main change is requesting support can adding multiple stylesheets (then some doc updates around that).
I think this is close 👍

[Baptiste Mispelon]

I've pushed an update with support for both single and multiple stylesheets. I think this is shaping up nicely, I'm enjoying the review process!