Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#12802 closed (fixed)

InlineModelAdmin.form: inlineformset_factory, not formset_factory

Reported by: Tay Ray Chuan Owned by: unbracketed
Component: Documentation Version: 1.1
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The ​documentation for the form member of !InlineModelAdmin writes that formset_factory is invoked.

As ​line 1160 of django/contrib/admin/options.py reads, it is inlineformset_factory that is invoked, not formset_factory.

Change History (5)

comment:1 by unbracketed, 15 years ago

Owner: changed from nobody to unbracketed
Status: new → assigned

by unbracketed, 15 years ago

Attachment: 12802_update_doc.diff​ added

Changes formset_factory to inlineformset_factory

comment:2 by unbracketed, 15 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

I verified that the form is indeed passed to in django.contrib.admin.options at the last line of InlineModelAdmin.get_formset (currently L1230).

The patch updates the documentation accordingly.

comment:3 by jbronn, 15 years ago

Resolution: → fixed
Status: assigned → closed

(In [12528]) Fixed #12802 -- Specify the correct factory in the InlineModelAdmin docs. Thanks, rctay and unbracketed.

comment:4 by jbronn, 15 years ago

(In [12529]) [1.1.X] Fixed #12802 -- Specify the correct factory in the InlineModelAdmin docs. Thanks, rctay and unbracketed.

Backport of r12527 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top