Django

Code

Ticket #1280 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[magic-removal] Update django.contrib.contenttypes for magic-removal

Reported by: Esaj Assigned to: adrian
Milestone: Component: django.contrib.admin
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

django.contrib.contenttypes currently uses the old, magic way of getting model objects.

I propose:

  • Get rid of the 'Package' model - is there any use for it now that the magic has gone?
  • Replace ContentType?'s 'package' and 'python_module_name' fields with a 'model' field.

Attachments

models.py.diff (2.3 kB) - added by Esaj on 01/26/06 12:17:57.
contenttypes.diff (10.4 kB) - added by Esaj on 02/07/06 17:55:24.

Change History

01/26/06 12:17:57 changed by Esaj

  • attachment models.py.diff added.

02/07/06 17:55:24 changed by Esaj

  • attachment contenttypes.diff added.

02/07/06 17:57:12 changed by Esaj

The latest patch (contenttypes.diff) updates django.contrib.auth and django.core.management to support the changes as well. I've tested this and it seems to work fine.

02/27/06 11:58:29 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [2411]) magic-removal: Fixed #1280 -- Removed contenttypes.Package model and changed ContentType? field to have a 'model' field

Add/Change #1280 ([magic-removal] Update django.contrib.contenttypes for magic-removal)




Change Properties
Action