Django

Code

Ticket #12726 (closed: fixed)

Opened 6 months ago

Last modified 6 months ago

double {{ media }} in admin templates...

Reported by: jedie Assigned to: jezdez
Milestone: Component: django.contrib.admin
Version: SVN Keywords: media
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I have double media files in some admin panel views. See: http://paste.pocoo.org/show/171364/

There is two times {{ media }} in the file contrib/admin/templates/admin/change_list.html since changeset 12298 One in {% block extrastyle %} and one in {% block extrahead %}

This is a bug, isn't it?

Discuss: http://groups.google.com/group/django-developers/browse_thread/thread/a74b50c5419b3251

Attachments

change_list_patch.txt (0.8 kB) - added by jedie on 01/29/10 04:44:03.

Change History

01/29/10 04:44:03 changed by jedie

  • attachment change_list_patch.txt added.

01/29/10 04:45:13 changed by jedie

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

I also notice, that change_list.html doesn't has a {{ block.super }} in {% block extrahead %}...

I added change_list_patch.txt to change {{ medie }} with {{ block.super }}

01/29/10 08:55:16 changed by jezdez

  • owner changed from nobody to jezdez.
  • status changed from new to assigned.
  • stage changed from Unreviewed to Accepted.

01/29/10 14:44:26 changed by ebartels@gmail.com

Is there any reason not to split it up and have a call to {{media.css}} inside extrastyle block, and then {{media.js}} inside extrahead?

02/01/10 08:12:25 changed by jezdez

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [12365]) Fixed #12726 - Prevent listing media twice in admin's change list. Thanks, jedie.

Add/Change #12726 (double {{ media }} in admin templates...)




Change Properties
Action