#12613 closed (fixed)
phone2numeric doesn't convert the letters 'Q' or 'Z'.
| Reported by: | Gabriel Hurley | Owned by: | Gabriel Hurley |
|---|---|---|---|
| Component: | Template system | Version: | 1.1 |
| Severity: | Keywords: | phone2numeric | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Discussion on the django developers group here: http://groups.google.com/group/django-developers/browse_frm/thread/49ee1863efa59901
There doesn't seem to be any good reason for the phone2numeric function not to convert the letters Q or Z, so I've created a small patch that remedies that.
Also, for readability's sake the patch puts the dictionary of letter-to-number conversions in alphabetical order.
Attachments (2)
Change History (8)
by , 16 years ago
| Attachment: | phone2numeric_complete.diff added |
|---|
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 16 years ago
| Needs tests: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Could use a test that breaks currently and passes with the patch.
by , 16 years ago
| Attachment: | phone2numeric_complete_test.diff added |
|---|
Adds test for phone2numeric that uses a full English pangram plus hyphen and exclamation point.
comment:3 by , 16 years ago
| Needs tests: | unset |
|---|
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 by , 16 years ago
Note:
See TracTickets
for help on using tickets.
Adds support for Q and Z in the phone2numeric function.