django.contrib.auth.forms.UserCreationForm.clean doesn't return cleaned_data dictionary

[Gregor Müllegger]

The clean() method of django.contrib.auth.forms.UserCreationForm looks like this (trunk version)

    def clean(self):
        # Fill the password field so model validation won't complain about it
        # being blank. We'll set it with the real value below.
        self.instance.password = UNUSABLE_PASSWORD
        super(UserCreationForm, self).clean()

It is missing a return statement that returns the cleaned_data dictionary. Because of that the form.cleaned_data attribute will be None after validating the form.

I think this behaviour is not intended -- athorwise there would be a comment.

[jasongreen]

I have the same problem..

[jonlesser]

I am also having this problem in r12205. The form's save() function returns the new user, so I am able to access "cleaned" data from there, but it seems cleaner to have access to cleaned data.

[jkocherhans]

(In [12206]) Fixed #12512. Changed ModelForm to stop performing model validation on fields that are not part of the form. Thanks, Honza Kral and Ivan Sagalaev.
This reverts some admin and test changes from [12098] and also fixes #12507, #12520, #12552 and #12553.