Opened 15 years ago

Closed 10 years ago

#12441 closed New feature (fixed)

Delegate module permissions check to AdminSite

Reported by: Alexander Koshelev Owned by: nobody
Component: contrib.admin Version: 1.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Just now only ModelAdmin has method like has_model_perms to check current user (more generic - request) permissions. But AdminSite checks module (application) permissions directly by accessing user's has_module_perms.

Given patch extracts this check to AdminSite method -- has_module_perms. That allows to use custom permission management subsystem to use in the entire admin interface.

Attachments (1)

12441.diff​ (1.9 KB ) - added by Alexander Koshelev 15 years ago.
patch

Download all attachments as: .zip

Change History (11)

by Alexander Koshelev, 15 years ago

Attachment: 12441.diff​ added

patch

comment:1 by Jannis Leidel, 15 years ago

Needs tests: set
Triage Stage: Unreviewed → Accepted

comment:2 by Alexander Koshelev, 15 years ago

Needs tests: unset

I think that no additional tests are needed for this patch. All current admin's tests implicitly checks that changes.

comment:3 by jkocherhans, 15 years ago

milestone: 1.2 → 1.3

1.2 is feature-frozen. Punting to 1.3.

comment:4 by Alexander Koshelev, 14 years ago

Component: Contrib apps → django.contrib.admin

comment:5 by Matt McClanahan, 14 years ago

milestone: 1.3
Severity: → Normal
Type: → New feature

comment:6 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:7 by Aymeric Augustin, 13 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:8 by Tomek Paczkowski, 10 years ago

Patch needs improvement: set

Patch no longer applies cleanly.

comment:9 by Nick Sandford, 10 years ago

Patch needs improvement: unset

Looks like this is fixed in master as of ​https://github.com/django/django/commit/504c89e8008c557a1e83c45535b549f77a3503b2.

comment:10 by Nick Sandford, 10 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.
Back to Top