Opened 16 years ago

Last modified 14 years ago

#12073 closed

AdminDateWidget and AdminTimeWidget not passing though additional attrs — at Version 1

Reported by: elliss Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords: widgets date time calendar
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Karen Tracey)

Suggest a change to allow additional user-defined attributes to be passed though. currently they're passed in but not though:

CURRENT:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminDateWidget, self).__init__(attrs={'class': 'vDateField', 'size': '10'})

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminTimeWidget, self).__init__(attrs={'class': 'vTimeField', 'size': '8'})

SUGGESTED:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vDateField', 'size': '10'})
        super(AdminDateWidget, self).__init__(attrs=attrs)

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vTimeField', 'size': '8'})
        super(AdminTimeWidget, self).__init__(attrs=attrs)

Change History (1)

comment:1 by Karen Tracey, 16 years ago

Description: modified (diff)

Fixed formatting. Please use WikiFormatting and the preview button.

Note: See TracTickets for help on using tickets.
Back to Top