AdminDateWidget and AdminTimeWidget not passing though additional attrs

[elliss]

Suggest a change to allow additional user-defined attributes to be passed though. currently they're passed in but not though:

CURRENT:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminDateWidget, self).__init__(attrs={'class': 'vDateField', 'size': '10'})

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        super(AdminTimeWidget, self).__init__(attrs={'class': 'vTimeField', 'size': '8'})

SUGGESTED:

class AdminDateWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vDateField', 'size': '10'})
        super(AdminDateWidget, self).__init__(attrs=attrs)

class AdminTimeWidget(forms.TextInput):
    class Media:
        js = (settings.ADMIN_MEDIA_PREFIX + "js/calendar.js",
              settings.ADMIN_MEDIA_PREFIX + "js/admin/DateTimeShortcuts.js")

    def __init__(self, attrs={}):
        attrs.update({'class': 'vTimeField', 'size': '8'})
        super(AdminTimeWidget, self).__init__(attrs=attrs)

[Karen Tracey]

Fixed formatting. Please use WikiFormatting and the preview button.

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[anonymous]

attrs.update() is maybe too simple - that still wouldn't allow to change (or just add) a CSS class or change the size

[Koen Biermans]

patch with test for 12073

[Koen Biermans]

The attached patch allows passing attrs into AdminDateWidget and AdminTimeWidget. Added a test too.

[Julien Phalip]

In [17125]:

Fixed #12073 -- Made AdminDateWidget and AdminTimeWidget consider user-supplied attrs. Thanks to elliss for the report and to koenb for the patch.