Opened 16 years ago

Closed 10 years ago

#11941 closed Bug (duplicate)

FilteredMultipleSelect does not render help text

Reported by: techieone Owned by: nobody
Component: Forms Version: 1.1
Severity: Normal Keywords:
Cc: Germano Gabbianelli Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The FilteredMultipleSelect in the admin widgets suite can be imported and used in other forms. However, it does not render any helptext whether that helptext was defined on the model field or the form field.

Attachments (1)

patch.diff​ (1.1 KB ) - added by Germano Gabbianelli 15 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Russell Keith-Magee, 16 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Germano Gabbianelli, 15 years ago

The help text is not displayed because SelectFilter2.js removes all paragraphs that "get in the way".

        // Remove <p class="info">, because it just gets in the way.
        var ps = from_box.parentNode.getElementsByTagName('p');
        for (var i=0; i<ps.length; i++) {
            from_box.parentNode.removeChild(ps[i]);
        }

I think the problem may be solved by reinserting these <p> after the widget has been created.
I made a patch for the js that works for me, but the paragraphs are displayed at the right of the widget and not at the bottom as I think they should.
Unfortunately I am not able to fix the css ...

Here's a screenshot, ​http://img337.imageshack.us/img337/5863/schermataadddummymodeld.png

by Germano Gabbianelli, 15 years ago

Attachment: patch.diff​ added

comment:3 by Germano Gabbianelli, 15 years ago

Has patch: set

comment:4 by Germano Gabbianelli, 15 years ago

Cc: Germano Gabbianelli added

comment:5 by Julien Phalip, 15 years ago

Severity: → Normal
Type: → Bug

comment:6 by patchhammer, 15 years ago

Easy pickings: unset
Patch needs improvement: set

patch.diff fails to apply cleanly on to trunk

comment:7 by Aymeric Augustin, 14 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:8 by Tim Graham, 10 years ago

Resolution: → duplicate
Status: new → closed

Duplicate of #6183 -- fixed in Django 1.3.

Note: See TracTickets for help on using tickets.
Back to Top