Django

Code

Ticket #11834 (assigned)

Opened 1 year ago

Last modified 2 weeks ago

Colorized technical_500_response: django code is green, user code is red.

Reported by: buriy Assigned to: buriy (accepted)
Milestone: 1.3 Component: User Experience
Version: 1.1 Keywords: colorize 500 http500 prettify
Cc: hv@tbz-pariv.de, gonz Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Pretty debatable feature. Helps to grasp easily what parts of the frame belongs to django, and what to user.

Attachments

11834.png (80.9 kB) - added by buriy on 09/05/09 11:56:58.
How does it looks after applying patch
11834_2.png (68.0 kB) - added by buriy on 11/02/09 15:05:38.
Different stack
11834_green_yellow.patch (2.8 kB) - added by buriy on 02/04/10 00:35:05.
Screen shot 2010-02-03 at 18.39.27.png (125.2 kB) - added by buriy on 02/04/10 00:35:57.
Green-yellow
11834.2.patch (8.2 kB) - added by buriy on 03/19/10 05:44:11.
Patch allowing to customize debug colors.
11834.patch (8.2 kB) - added by buriy on 03/19/10 05:44:16.
Patch allowing to customize debug colors.

Change History

09/05/09 11:56:58 changed by buriy

  • attachment 11834.png added.

How does it looks after applying patch

11/02/09 15:05:38 changed by buriy

  • attachment 11834_2.png added.

Different stack

11/03/09 09:22:18 changed by guettli

  • cc set to hv@tbz-pariv.de.
  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

02/03/10 08:40:06 changed by russellm

  • needs_better_patch set to 1.
  • stage changed from Unreviewed to Accepted.

Reasonable suggestion, but probably calls for different colour choices. To me, Red/Green implies stop/go or broken/good, which isn't the intention. There's nothing wrong with the existing stack trace colors, IMHO - we just need to pick a way to make a distinction between user and internal code. Collapsing the 'django' portions of the stack is another option.

02/04/10 00:35:05 changed by buriy

  • attachment 11834_green_yellow.patch added.

02/04/10 00:35:57 changed by buriy

  • attachment Screen shot 2010-02-03 at 18.39.27.png added.

Green-yellow

02/04/10 00:39:40 changed by buriy

  • status changed from new to assigned.

My friend designed suggested the green-yellow color scheme fix, i've updated patch and added new screenshot. How about this version? I like it even more.

03/18/10 19:40:39 changed by russellm

  • component changed from HTTP handling to User Experience.

#13148 made some additional suggestions regarding the debug page, raising the UX issues for the debug page again.

I'm going to move this to the UX component so we can get some designer mojo on it.

03/19/10 05:44:11 changed by buriy

  • attachment 11834.2.patch added.

Patch allowing to customize debug colors.

03/19/10 05:44:16 changed by buriy

  • attachment 11834.patch added.

Patch allowing to customize debug colors.

03/19/10 05:49:34 changed by buriy

  • needs_better_patch deleted.
  • needs_docs set to 1.
  • needs_tests set to 1.
  • milestone set to 1.3.

Russell, great idea. I added also a better patch, that allows changeable and controllable colors. It's not in RFC state (docs & constants are inlined), but overall it's very good prove of the concept, and you can play with it.

But if we considering real improvements of the debug pages, I'd also add a way to do werkzeug-style of post-mortem inplace-debugging, also reducing default output, and a better output for template frames.

08/12/10 10:35:10 changed by gonz

  • cc changed from hv@tbz-pariv.de to hv@tbz-pariv.de, gonz.

08/16/10 01:55:29 changed by guettli

  • needs_docs deleted.
  • needs_tests deleted.

Thread on django-dev http://groups.google.de/group/django-developers/browse_frm/thread/bd43e2e040a17784/

Add/Change #11834 (Colorized technical_500_response: django code is green, user code is red.)




Change Properties
Action