Admin actions javascript problem in Firefox.

[Vasil Vangelovski]

Not sure if others consider this a bug or the way this JS should behave, so please discuss this.
In the admin changelist when the user checks some checkbox/es they are highlighted yellow, but in firefox when the page is refreshed this form isn't getting reset so previously checked checkboxes are left checked but not highlighted (after a refresh on the changelist page).
I'm submitting a patch for this, it's just 5 lines of code added to the actions.js, but as I said I find this an aesthetic flaw and I'm not really sure if it was left like that intentionally.

[Vasil Vangelovski]

patch

[Alex Gaynor]

Not a critical blocker for 1.1.

[Collin Anderson]

for(var i in actionCheckboxes) {

I think this can lead to some problems if someone wants to use prototype or some other javascript framework in the admin.

for(var i = 0; i < actionCheckboxes.length; i++) {

This is safer.

[Vasil Vangelovski]

Update for the patch

[Vasil Vangelovski]

Replying to CollinAnderson:

for(var i in actionCheckboxes) {

I think this can lead to some problems if someone wants to use prototype or some other javascript framework in the admin.

for(var i = 0; i < actionCheckboxes.length; i++) {

This is safer.

Thanks. Never used prototype exactly because of this :). I've uploaded the improved version.

[patchhammer]

django-admin-actions.2.patch fails to apply cleanly on to trunk

[Chi Shang Cheng]

I have been unable to reproduce this issue in Firefox-3.5, Firefox-3.6 and Firefox-4.0. I haven't tested older Firefox versions, because I couldn't find the tarballs on the official mirrors. But their market share is negligible (of Firefox-2.0 and Firefox-3.0).

The issue has probably been fixed by a previous jQuery update sometime ago. I think this ticket can be closed.

[Vasil Vangelovski]

I was experiencing this with Firefox 3.something before the admin started using jQuery. It's fixed since 1.2,