Django Admin no longer uses never_cache, breaks with site-wide cache

[Michael Newman]

When site cache is enabled using middleware

    'django.middleware.cache.UpdateCacheMiddleware',
    'django.middleware.cache.FetchFromCacheMiddleware',

The admin site is broken because the never_cache decorators have been removed from the views.

[James Bennett]

AdminSite applies the never_cache decorator as part of its internal dispatch to the ModelAdmin class; see around line 500 of contrib/admin.sites.py.

[Michael Newman]

The model_page function you are referring to is no longer used by the new get_urls function. Am I missing something else?

[Michael Newman]

I hate to reopen my own ticket, but I am sure that the new urls don't properly receive the cache headers.

[Michael Newman]

Patch with a test to ensure there is a max-age on the response from the admin

[Ramiro Morales]

S slightly modified approach for the patch

[Ramiro Morales]

The attached patch implements something Alex Gaynor suggested on IRC: Moving the addition of never_cache decorator application to the admin_view AdminSite method.

The patchs also:

• Adds a test for a non-model-specific view like an app index view so both AdminSite and ModelAdmin behaviour is tested.
• Adds documentation.

[Michael Newman]

Slightly modified version of the patch Ramiro uploaded, without some unrelated import and spacing changes and because admin_site.admin_view is used in the wrapper in the ModelAdmin views, there is no need for a decorator change in the ModelAdmin

[Michael Newman]

I am going to mark this to 1.1 milestone since it will break some deployments and is unexpected behavior. Also this is functionality that has been downgraded in the admin since 1.0. If someone feels otherwise, please feel free to change.

[Russell Keith-Magee]

(In [11229]) Fixed #11416 -- Restored use of the never_cache decorator on admin views. Thanks to Ramiro Morales and Michael Newmann for their work on the patch.

[Jacob]

Milestone 1.1 deleted