Django

Code

Ticket #11373 (new)

Opened 8 months ago

Last modified 2 months ago

Change list layout breaks if no actions_form

Reported by: manuel_razzari Assigned to:
Milestone: Component: django.contrib.admin
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The documented ways to remove all admin actions (actions=None and disable_action) are causing minor but visible layout breakage on the change list page.

The template seems to be comparing against the wrong variables. Also, text-align is missing in the CSS override to restore the TH to its original layout.

Attaching screenshot and patch.

Attachments

change_list.patch (0.6 kB) - added by manuel_razzari on 06/25/09 10:19:31.
Proposed patch
change_list.gif (14.4 kB) - added by manuel_razzari on 06/25/09 10:21:04.
Screenshot reproducing the issue
patch-changelist.diff (1.8 kB) - added by mpaolini on 09/01/09 14:16:34.
alternative patch

Change History

06/25/09 10:19:31 changed by manuel_razzari

  • attachment change_list.patch added.

Proposed patch

06/25/09 10:21:04 changed by manuel_razzari

  • attachment change_list.gif added.

Screenshot reproducing the issue

06/25/09 16:17:40 changed by ubernostrum

  • needs_better_patch changed.
  • needs_docs changed.
  • needs_tests changed.
  • milestone deleted.

Only extremely critical bugs are being accepted for the 1.1 milestone right now.

08/08/09 15:29:00 changed by Alex

  • stage changed from Unreviewed to Accepted.

09/01/09 14:16:34 changed by mpaolini

  • attachment patch-changelist.diff added.

alternative patch

09/01/09 14:16:57 changed by mpaolini

I'm submitting an alternate patch based on the original.

I believe this one is cleaner 'cause all css code is kept in stylesheet no (extra <style> in change_list.html)

12/14/09 15:14:02 changed by jacob

  • owner deleted.

Add/Change #11373 (Change list layout breaks if no actions_form)




Change Properties
Action