Opened 16 years ago
Closed 15 years ago
#11373 closed (fixed)
Change list layout breaks if no actions_form
| Reported by: | Manuel Razzari | Owned by: | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The documented ways to remove all admin actions (actions=None and disable_action) are causing minor but visible layout breakage on the change list page.
The template seems to be comparing against the wrong variables. Also, text-align is missing in the CSS override to restore the TH to its original layout.
Attaching screenshot and patch.
Attachments (3)
Change History (8)
by , 16 years ago
| Attachment: | change_list.patch added |
|---|
comment:1 by , 16 years ago
| milestone: | 1.1 |
|---|
Only extremely critical bugs are being accepted for the 1.1 milestone right now.
comment:2 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 16 years ago
I'm submitting an alternate patch based on the original.
I believe this one is cleaner 'cause all css code is kept in stylesheet no (extra <style> in change_list.html)
comment:4 by , 16 years ago
| Owner: | removed |
|---|
comment:5 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I can't seem to be able to reproduce this, so I assume it has been fixed in a previous changeset. If you disagree, please reopen and provide a concrete code example that we can test.
Proposed patch