Django

Code

Ticket #11357 (closed: fixed)

Opened 9 months ago

Last modified 9 months ago

contrib.admindocs ignores many-to-many relations

Reported by: ubernostrum Assigned to: nobody
Milestone: Component: Contrib apps
Version: 1.0 Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

It's a one-line patch; needs to look at _meta.get_all_related_many_to_many_objects() when collecting related objects.

Attachments

admindocs-m2m.diff (0.6 kB) - added by ubernostrum on 06/23/09 10:01:40.
admindocs-m2m-both-ways.diff (1.4 kB) - added by ubernostrum on 06/23/09 10:47:28.
New patch; respects both sides of the m2m
admindocs-m2m-both-ways-2.patch (1.7 kB) - added by benspaulding on 06/23/09 11:26:16.
Added <field>.count, and other consistency changes.

Change History

06/23/09 10:01:40 changed by ubernostrum

  • attachment admindocs-m2m.diff added.

06/23/09 10:47:28 changed by ubernostrum

  • attachment admindocs-m2m-both-ways.diff added.

New patch; respects both sides of the m2m

06/23/09 11:25:32 changed by benspaulding

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

I have taken the admindocs-m2m-both-ways.diff patch and updated it so it is consistent with other relationships. <field>.count is now listed and the data type of <field>.all is changed to List.

However, I simply copied how it was done for the other relations — maybe there is a better/cleaner way of doing this, rather than repeating these parts.

06/23/09 11:26:16 changed by benspaulding

  • attachment admindocs-m2m-both-ways-2.patch added.

Added <field>.count, and other consistency changes.

06/30/09 14:04:09 changed by Alex

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r11127

Add/Change #11357 (contrib.admindocs ignores many-to-many relations)




Change Properties
Action