Support i18n tags in templates with .js extension

[Andrew Badr]

We are using dynamically generated javascript that includes strings for translation. These are marked with the trans template tag. There is no way to get these strings added to a pofile, since makemessages forcefully rejects the 'js' extension.

[Malcolm Tredinnick]

Have a look at the "-e" option to django-admin.py makemessages (django-admin.py help makemessages).

[Ramiro Morales]

Malcolm, actually I think we are eplicitly rejecting the .js extension when the user specifies it with the -e/--extension command line option: ​http://code.djangoproject.com/browser/django/trunk/django/core/management/commands/makemessages.py?rev=10833#L226

[Malcolm Tredinnick]

Ah, I understand what you (both) are saying now. My mistake. Okay, we need to let people shoot themselves in the foot so that people doing the right thing can get their work done. This is definitely worth changing, because Django's current approach to i18n in Javascript is pretty cache unfriendly, so allowing workarounds for when it's appropriate is a Good Thing.

[Ramiro Morales]

SImple patch

[Jannis Leidel]

(In [12439]) Fixed #11284 - Stop forcing the use of the djangojs domain when the ".js" file extension is passed to makemessages management command. Thanks, Ramiro Morales.

[Jannis Leidel]

(In [12450]) [1.1.X] Fixed #11284 - Stop forcing the use of the djangojs domain when the ".js" file extension is passed to makemessages management command. Thanks, Ramiro Morales.

Backport of r12439.

[Jacob]

Milestone 1.2 deleted