Hidden fields in Inlines are displayed as empty rows

[Martin Mahner]

A field with an Hiddeninput widget is displayed as an empty row in the inline in admin. See screenshot for explanation.

Here is the code I use:

class LocationForm(forms.ModelForm):
    latitude = forms.FloatField(widget=forms.HiddenInput)
    longitude = forms.FloatField(widget=forms.HiddenInput)

class LocationInline(generic.GenericStackedInline):
    model = Location
    form = LocationForm
    extra = 1
    max_num = 1

[Alex Gaynor]

a) What fields on are Location

b) What do you expect to happen?

[Alex Gaynor]

No new information after 2 months, closing as worksforme.

[Narcélio Filho]

The issue is that labels are still being rendered on forms, even when the field is hidden. Labels should not be rendered if field is hidden, right?

(Maybe the problem is at django/contrib/admin/templates/admin/includes/fieldset.html or AdminField.label_tag().)

Checkout a discussion about that:

​How do I hide the field label for a HiddenInput widget in Django Admin?

[Julien Phalip]

#14372 was closed as dupe and contains a patch.

[Ben Boyd <beathan@…>]

I've attached 2 diffs as a proposed patch for this issue, tested on the latest trunk. One adds has_hidden_field to Fieldline in django/contrib/admin/helpers.py, marking it True if self.fields contains a field with a hidden widget, and another for django/contrib/admin/templates/admin/includes/fieldset.html, which outputs only the fields themselves if line.has_hidden_field is True.

[Pieter Swinkels]

DjangoCon Europe 2011 sprint: commenced work on this ticket

[Pieter Swinkels]

test project to reproduce the reported problem

[Pieter Swinkels]

I tested it with the project I just attached but I cannot reproduce the problem.

[Julien Phalip]

The patch needs tests. It also needs to cater for when the Fieldline contains only one, hidden, field (in which case the entire row, including the label and help_text, show be hidden -- see #7859 and #14372), or when it contains a mix of hidden and non-hidden fields (in which case the row should be displayed and the non-hidden fields should also be displayed correctly).

By the way, I could reproduce the issue with the following code:

# models.py

from django.db import models
from django.contrib.contenttypes.models import ContentType
from django.contrib.contenttypes import generic

class Restaurant(models.Model):
    name = models.CharField(max_length=200)

class Location(models.Model):
    content_type = models.ForeignKey(ContentType)
    object_id = models.PositiveIntegerField()
    content_object = generic.GenericForeignKey('content_type', 'object_id')
    longitude = models.FloatField(blank=True)
    latitude = models.FloatField(blank=True)

# admin.py

from django.contrib import admin
from django import forms
from django.contrib.contenttypes.generic import GenericStackedInline

from .models import Restaurant, Location

class LocationForm(forms.ModelForm):
    latitude = forms.FloatField(widget=forms.HiddenInput)
    longitude = forms.FloatField(widget=forms.HiddenInput)

class LocationInline(GenericStackedInline):
    model = Location
    form = LocationForm
    extra = 1
    max_num = 1

class RestaurantAdmin(admin.ModelAdmin):
    inlines = [LocationInline]

admin.site.register(Restaurant, RestaurantAdmin)

This is however not tied to generic inlines in particular, but is relevant to any form of any kind (main forms, regular inline forms and generic inline forms).

[chrismedrela]

Pull request: ​https://github.com/django/django/pull/789. Reviewed by rsiera.

[Tim Graham]

Patch no longer applies cleanly.

[Russell Keith-Magee]

​Pull request #1260 was provided as a fix for this ticket; still not RFC, though. Comments on the pull request.

[Tim Graham <timograham@…>]

In dc3d2ac98c1bcfad74d3e9523caf07e7e9fb15aa:

Fixed #11277 -- Hid labels of fields with HiddenInput widget in admin forms.

Thanks bartTC for the report.