Django

Code

Ticket #1099 (closed: wontfix)

Opened 3 years ago

Last modified 2 years ago

[patch] Enable usage of absolute path for admin js option

Reported by: Nebojša Đorđević - nesh <nesh@studioquattro.co.yu> Assigned to: adrian
Milestone: Component: Admin interface
Version: Keywords:
Cc: nesh@studioquattro.co.yu Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

With this patch if admin.js parameter is used with absolute URL, ADMIN_MEDIA_URL is not added in front of it.

This way we don't need to link additional JS files into ADMIN_MEDIA_URL/js/ directory.

Attachments

admin.diff (0.9 kB) - added by Nebojša Đorđević - nesh <nesh@studioquattro.co.yu> on 12/21/05 12:58:39.
admin_media_prefix_allow_absolute_paths.diff (0.8 kB) - added by Tom Tobin <korpios@gmail.com> on 06/07/06 20:08:42.
My take on the fix for this issue; supports http(s):// and uses urljoin.

Change History

12/21/05 12:58:39 changed by Nebojša Đorđević - nesh <nesh@studioquattro.co.yu>

  • attachment admin.diff added.

12/21/05 12:59:00 changed by Nebojša Đorđević - nesh <nesh@studioquattro.co.yu>

  • cc set to nesh@studioquattro.co.yu.

01/05/06 12:05:44 changed by joeboy

It would also be good (and trivial) to be able to specify a full url, ie. http://somesite.com/scripts/somescript.js

02/26/06 10:05:12 changed by adrian

  • status changed from new to closed.
  • resolution set to wontfix.

We're going to remove the admin.js option entirely, in favor of custom admin templates, so I'm marking this as a wontfix.

06/07/06 20:08:42 changed by Tom Tobin <korpios@gmail.com>

  • attachment admin_media_prefix_allow_absolute_paths.diff added.

My take on the fix for this issue; supports http(s):// and uses urljoin.

06/07/06 20:11:30 changed by Tom Tobin <korpios@gmail.com>

  • status changed from closed to reopened.
  • resolution deleted.

I thought I'd add my crack at this issue; as it's been three months since this ticket was closed, and it's still an annoying issue today (IMHO), I don't feel that applying a fix right now would be detrimental unless those custom admin templates are arriving tomorrow. :)

08/03/06 00:00:09 changed by Tom Tobin <korpios@gmail.com>

  • status changed from reopened to closed.
  • resolution set to wontfix.

Forgive me, for I know not what I was high on; custom admin templates are indeed a much better solution, as I've discovered. :-D

Add/Change #1099 ([patch] Enable usage of absolute path for admin js option)




Change Properties
Action