#10927 closed (fixed)
Content Types shortcut view throws 500s easily
| Reported by: | Jeremy Dunck | Owned by: | nobody |
|---|---|---|---|
| Component: | Contrib apps | Version: | 1.1-beta |
| Severity: | Keywords: | ||
| Cc: | semente@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
BaseHandler.handle_uncaught_exception calls mail_admins any time an uncaught exception occurs. In my general usage, this is very rare.
The contenttypes.views.shortcut view, many arbitrary URLs will throw a 500. Since crawlers probe URL spaces, this leads to a lot of noise in error emails.
Attachments (2)
Change History (10)
by , 17 years ago
| Attachment: | 10927.diff added |
|---|
comment:1 by , 17 years ago
| Has patch: | set |
|---|
comment:2 by , 17 years ago
Why does this raise a 404 if the PK isn't an integer? That's not the correct behavior as we support all sorts of other pks.
comment:4 by , 17 years ago
The simpler one probably works-for-me. I chose the .to_python route because that uniformly raises ValidationError-- I wasn't sure about the assumption that any cast in the ORM would fail as ValueError.
comment:5 by , 16 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
Reviewed - looks good and the tests prove it works :)
comment:6 by , 16 years ago
| Cc: | added |
|---|
comment:7 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:8 by , 16 years ago
Note:
See TracTickets
for help on using tickets.
More robust shortcut view, with tests.