Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#10886 closed (fixed)

"Reversing Admin URLs" section provides invalid examples

Reported by: Simon Meers <DrMeers@…> Owned by: Jacob
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description 

urlresolvers.reverse('admin_polls_choice_change', (c.id,))

should be:

urlresolvers.reverse('admin_polls_choice_change', args=[c.id,])

otherwise (c.id,) is interpreted as the urlconf argument, and an error such as:

AttributeError: 'int' object has no attribute 'regex'

is raised, since (c.id,) is not a urlconf. The second example with custom_admin_... should also be changed.

Change History (7)

comment:1 by Alex Gaynor, 16 years ago

milestone: → 1.1
Triage Stage: Unreviewed → Accepted

by dc, 16 years ago

Attachment: reverse.patch​ added

comment:2 by George Song, 16 years ago

Has patch: set

comment:3 by Andy Durdin, 16 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Jacob, 16 years ago

Owner: changed from nobody to Jacob
Status: new → assigned

comment:5 by Alex Gaynor, 16 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in r10776.

comment:6 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top