List editable breaks with model inheritance and parent_link=True

[Will Hardy]

Similar symptoms to #10622, the admin site raises an exception where the model explicity defines a parent_link and list_editable is set in the model's admin.

I have attached a regression test that shows this in action.

[Will Hardy]

Regression test showing this bug in action

[Will Hardy]

A couple of extra bits of potentially useful information:

1. exception appears whether or not parent_link is set as a primary_key.

2. looking at line 950 of django/contrib/admin/options.py:

       elif self.list_editable:
           FormSet = self.get_changelist_formset(request)
           formset = cl.formset = FormSet(queryset=cl.result_list)
   

The FormSet here looks ok (parent_link and non-parent_link version appear to be the same), but each of the forms in formset.forms is missing the field for the primary key. The result_list is of course the same with or without parent_link.

I find this strange because it appears to use the (no doubt well-tested) generic factory functions from forms.models.

I don't know the internal django code well enough to give a useful opinion here, but this is what I was able to observe.

[Alex Gaynor]

Assigning to me.

[Will Hardy]

I probably should have given my regression test a more descriptive title and a docstring, eg:

    def test_inheritance_parent_link(self):
        " Ensure that the admin list_editable view works for models with parent_link. "

[Jacob]

(In [10590]) Fixed #10799: fixed the use of list_editable with model inheritance and custom one-to-one parent links. Thanks, Alex Gaynor.

[Jacob]

Milestone 1.1 deleted